Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755498Ab0GHIoK (ORCPT ); Thu, 8 Jul 2010 04:44:10 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:51790 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754647Ab0GHIoI (ORCPT ); Thu, 8 Jul 2010 04:44:08 -0400 Date: Thu, 8 Jul 2010 10:34:42 +0200 From: Anisse Astier To: Axel Lin Cc: linux-kernel , Matthew Garrett , Thomas Renninger , Richard Purdie , Carlos Corbacho , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] msi-wmi: make needlessly global symbols static Message-ID: <20100708103442.28520f6f@destiny.ordissimo> In-Reply-To: <1278553830.7162.9.camel@mola> References: <1278553830.7162.9.camel@mola> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 36 Hi Axel, On Thu, 08 Jul 2010 09:50:30 +0800, Axel Lin wrote : > backlight is needlessly defined global. > This patch makes the symbol static. > > Signed-off-by: Axel Lin Acked-by: Anisse Astier Thanks, Anisse > --- > drivers/platform/x86/msi-wmi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index d173600..42a5469 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = { > }; > static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1]; > > -struct backlight_device *backlight; > +static struct backlight_device *backlight; > > static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/