From: Arnd Bergmann <arnd@arndb.de>
To: Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH 06/18] spufs: use llseek in all file operations
Date: Thu, 8 Jul 2010 15:02:36 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Christoph Hellwig <hch@lst.de>, linuxppc-dev@ozlabs.org
References: <1278538820-1392-1-git-send-email-arnd@arndb.de> <1278538820-1392-7-git-send-email-arnd@arndb.de> <1278551728.28333.55.camel@pororo.lan>
In-Reply-To: <1278551728.28333.55.camel@pororo.lan>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201007081502.37133.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1360
Lines: 33

On Thursday 08 July 2010, Jeremy Kerr wrote:
> > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file *file, char __user *buf,
> >  static const struct file_operations spufs_ibox_info_fops = {
> >       .open = spufs_info_open,
> >       .read = spufs_ibox_info_read,
> > -     .llseek  = generic_file_llseek,
> > +     .llseek = no_llseek,
> >  };
> > 
> >  static ssize_t __spufs_wbox_info_read(struct spu_context *ctx,
> > @@ -2194,7 +2209,7 @@ static ssize_t spufs_wbox_info_read(struct file *file, char __user *buf,
> >  static const struct file_operations spufs_wbox_info_fops = {
> >       .open = spufs_info_open,
> >       .read = spufs_wbox_info_read,
> > -     .llseek  = generic_file_llseek,
> > +     .llseek = no_llseek,
> >  };
> > 
> 
> Why the change in behaviour for the mbox info files?
> 

D'oh, that wasn't intentional. I guess what must have happened is that I first
added generic_file_llseek to all file_operations in spufs and then made up my
mind and chose what I thought was correct in each case, which broke these.
Of course, these *_info_fops should be seekable.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/