Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757165Ab0GHOFk (ORCPT ); Thu, 8 Jul 2010 10:05:40 -0400 Received: from nlpi129.sbcis.sbc.com ([207.115.36.143]:36257 "EHLO nlpi129.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704Ab0GHOFi (ORCPT ); Thu, 8 Jul 2010 10:05:38 -0400 Date: Thu, 8 Jul 2010 09:04:18 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: KOSAKI Motohiro cc: LKML , linux-mm , Andrew Morton , Mel Gorman , Rik van Riel , Minchan Kim , Johannes Weiner Subject: Re: [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order In-Reply-To: <20100708163934.CD37.A69D9226@jp.fujitsu.com> Message-ID: References: <20100708163401.CD34.A69D9226@jp.fujitsu.com> <20100708163934.CD37.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 17 On Thu, 8 Jul 2010, KOSAKI Motohiro wrote: > Fix simple argument error. Usually 'order' is very small value than > lru_pages. then it can makes unnecessary icache dropping. AFAICT this is not argument error but someone changed the naming of the parameter. The "lru_pages" parameter is really a division factor affecting the number of pages scanned. This patch increases this division factor significantly and therefore reduces the number of items scanned during zone_reclaim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/