Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756682Ab0GHSm5 (ORCPT ); Thu, 8 Jul 2010 14:42:57 -0400 Received: from kroah.org ([198.145.64.141]:54291 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754970Ab0GHSmx (ORCPT ); Thu, 8 Jul 2010 14:42:53 -0400 Date: Thu, 8 Jul 2010 11:34:25 -0700 From: Greg KH To: Michal Nazarewicz Cc: linux-usb@vger.kernel.org, Alan Stern , David Brownell , Kyungmin Park , Marek Szyprowski , linux-kernel@vger.kernel.org, Dries Van Puymbroeck , stable Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number Message-ID: <20100708183425.GB31823@kroah.com> References: <624a27be8a9a4492976afaa8df78c07051cc6e25.1277987700.git.m.nazarewicz@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <624a27be8a9a4492976afaa8df78c07051cc6e25.1277987700.git.m.nazarewicz@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 23 On Thu, Jul 01, 2010 at 03:42:19PM +0200, Michal Nazarewicz wrote: > This commit adds iSerialNumber to all gadgets that use the Mass > Storage Function. It appears that Windows has problems when > it is not set. > > Not to copy the same code all over again, a fsg_string_serial_fill() > macro has been added to the storage_common.c file which is now also > used in the File Storage Gadget. This patch conflicts with the patch in my tree: Subject: USB: Add a serial number parameter to g_file_storage module So, could you fix the above patch up to play nice with your change so that I can accept it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/