DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=qLgZpfmCMruDT8+Rsy4JifD8JsIy0r2+CfpHHFCAq7GDCI+FCwS8AdEjt0I+Y8ONLiAidPCzo48lcpNKYA+SrukZIT4vUIHJqo94MeuA0SlcZ4kk20kyPVGw4QqOiHkDFZ8P0r2HY27ndnlebXyAJIV7j0dyVmWnoUK/yhgL184=;
Message-ID: <425855.73532.qm@web180314.mail.gq1.yahoo.com>
Date: Thu, 8 Jul 2010 13:20:11 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number
To: Greg KH <greg@kroah.com>,
       =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
       Kyungmin Park <kyungmin.park@samsung.com>,
       Marek Szyprowski <m.szyprowski@samsung.com>,
       linux-kernel@vger.kernel.org,
       Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
       mina86@mina86.com
In-Reply-To: <op.vfjja62m7p4s8u@pikus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 722
Lines: 22

> > Can it be made to do so only when the gadget
> > hasn't been provided with one already?  Serial
> > number module options are standard parts of the
> > composite gadget framework...
> 
> I don't see a way for the gadget to know whether user gave
> the iSerialNumber
> parameter (other then reading the iSerialNumber variable
> but I consider that  ugly).

Uglier still is the current patch overriding
that explicitly-given parameter.

NAK until this issue is resolved.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/