Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756577Ab0GHVCq (ORCPT ); Thu, 8 Jul 2010 17:02:46 -0400 Received: from nlpi129.sbcis.sbc.com ([207.115.36.143]:57836 "EHLO nlpi129.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740Ab0GHVCp (ORCPT ); Thu, 8 Jul 2010 17:02:45 -0400 Date: Thu, 8 Jul 2010 16:01:48 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Andrew Morton cc: KOSAKI Motohiro , LKML , linux-mm , Mel Gorman , Rik van Riel , Minchan Kim , Johannes Weiner Subject: Re: [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order In-Reply-To: <20100708133152.5e556508.akpm@linux-foundation.org> Message-ID: References: <20100708163401.CD34.A69D9226@jp.fujitsu.com> <20100708163934.CD37.A69D9226@jp.fujitsu.com> <20100708133152.5e556508.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 32 On Thu, 8 Jul 2010, Andrew Morton wrote: > > AFAICT this is not argument error but someone changed the naming of the > > parameter. > > It's been there since day zero: > > : commit 2a16e3f4b0c408b9e50297d2ec27e295d490267a > : Author: Christoph Lameter > : AuthorDate: Wed Feb 1 03:05:35 2006 -0800 > : Commit: Linus Torvalds > : CommitDate: Wed Feb 1 08:53:16 2006 -0800 > : > : [PATCH] Reclaim slab during zone reclaim That only shows that the order parameter was passed to shrink_slab() which is what I remember being done intentionally. Vaguely recall that this was necessary to avoid shrink_slab() throwing out too many pages for higher order allocs. Initially zone_reclaim was full of heuristics that later were replaced by counter as the new ZVCs became available and gradually better ways of accounting for pages became possible. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/