Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757757Ab0GHVCv (ORCPT ); Thu, 8 Jul 2010 17:02:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756940Ab0GHVCt (ORCPT ); Thu, 8 Jul 2010 17:02:49 -0400 Date: Thu, 8 Jul 2010 18:02:28 -0300 From: Arnaldo Carvalho de Melo To: Thavidu Ranatunga Cc: linux-kernel@vger.kernel.org, Ian Munsie , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Christoph Hellwig Subject: Re: [PATCH 2/2] perf: Version String fix, for fallback if not from git Message-ID: <20100708210228.GI25306@ghostprotocols.net> References: <1278316815-6099-2-git-send-email-tharan@au1.ibm.com> <20100708205754.GH25306@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100708205754.GH25306@ghostprotocols.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 37 Em Thu, Jul 08, 2010 at 05:57:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jul 05, 2010 at 06:00:15PM +1000, Thavidu Ranatunga escreveu: > > This gets rid of the default version fallback for Perf and changes it so that it > > returns the version of the kernel from it's Makefile (if sources were not from > > git, ie. if it was downloaded from a tarball) > > Signed-off-by: Thavidu Ranatunga > > Signed-off-by: Ian Munsie > > > - VN="$DEF_VER" > > + eval `grep '^VERSION\s*=' ../../Makefile|tr -d ' '` > > + eval `grep '^PATCHLEVEL\s*=' ../../Makefile|tr -d ' '` > > + eval `grep '^SUBLEVEL\s*=' ../../Makefile|tr -d ' '` > > + eval `grep '^EXTRAVERSION\s*=' ../../Makefile|tr -d ' '` > > + > > + VN="${VERSION}.${PATCHLEVEL}.${SUBLEVEL}${EXTRAVERSION}" > > This makes 'make perf-tarbz2-src-pkg': > > [acme@emilia linux-2.6-tip]$ make perf-tarbz2-src-pkg > TAR > [acme@emilia linux-2.6-tip]$ mv perf-2.6.35-rc4.tar.bz2 /tmp > [acme@emilia linux-2.6-tip]$ cd /tmp > [acme@emilia tmp]$ tar xf perf-2.6.35-rc4.tar.bz2 > [acme@emilia tmp]$ cd perf-2.6.35-rc4/tools/perf > [acme@emilia perf]$ make > grep: ../../Makefile: No such file or directory > grep: ../../Makefile: No such file or directory But at least the 'make perf-tar*' targets aren't in perf/urgent, so I'll work on a fix for perf/core (aka 2.6.36). - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/