Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089Ab0GIC4o (ORCPT ); Thu, 8 Jul 2010 22:56:44 -0400 Received: from mail-ww0-f42.google.com ([74.125.82.42]:50690 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177Ab0GIC4m (ORCPT ); Thu, 8 Jul 2010 22:56:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=AN2nhtQeadbXR+5kCsZw1opIvTUdICeBhFhab5ajc9wS4F126ISrGufSiiNJtmOoof 4FP/Mx8TSU6zLAjxnrmQsoBearH0ezWGJ7diW4HN2syqHN/sJZCCAjfMTexezFqXKOTt il83AtbA+ql3hBWSV8sLUIFkxwjGAJe7gBBXQ= Date: Fri, 9 Jul 2010 04:56:30 +0200 From: Frederic Weisbecker To: Linus Torvalds Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Maciej Rutecki , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI , Al Viro , Shawn Starr , Jesse Barnes , Dave Airlie , "David S. Miller" , Patrick McHardy , Jens Axboe Subject: Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34 Message-ID: <20100709025628.GK6405@nowhere> References: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 43 On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote: > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki wrote: > > Bug-Entry ? ? ? : http://bugzilla.kernel.org/show_bug.cgi?id=16334 > > Subject ? ? ? ? : reiserfs locking (v2) > > Submitter ? ? ? : Sergey Senozhatsky > > Date ? ? ? ? ? ?: 2010-07-02 9:34 (7 days old) > > Message-ID ? ? ?: <20100702093451.GA3973@swordfish.minsk.epam.com> > > References ? ? ?: http://marc.info/?l=linux-kernel&m=127806306303590&w=2 > > Frederic? Al? I assume this is some late fallout from the BKL removal > ages ago.. It's the old filldir-vs-mmap crud, but normally it should > be impossible to trigger because the inode for a directory should > never be mmap'able, so we should never have the same i_mutex lock used > for both mmap and for filldir protection. > > We saw some of that oddity long ago, I wonder if it's lockdep being > confused about some inodes. I think it has been there from the beginning. At least it was there before the reiserfs bkl removal in .32. Indeed the readdir <-> unmap/release inversion problem can not happen. But Al said that can happen between write and release. (Although I don't see where write takes the inode mutex). He also highlighted the fact that reiserfs refcounting based on i_count was totally broken. He has a fix the whole in the vfs tree, in the for-next branch on commit 6c2bdaf089a3876226893fab00dd83596c465ad2 "Fix reiserfs_file_release()" No more uses of the i_mutex on release after that, nor i_count, but a private openers refcount and a tailpack mutex per reiserfs inode. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/