Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756811Ab0GIODY (ORCPT ); Fri, 9 Jul 2010 10:03:24 -0400 Received: from nlpi129.sbcis.sbc.com ([207.115.36.143]:33175 "EHLO nlpi129.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756743Ab0GIODV (ORCPT ); Fri, 9 Jul 2010 10:03:21 -0400 Date: Fri, 9 Jul 2010 09:02:31 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: KOSAKI Motohiro cc: Andrew Morton , LKML , linux-mm , Mel Gorman , Rik van Riel , Minchan Kim , Johannes Weiner Subject: Re: [PATCH] vmscan: stop meaningless loop iteration when no reclaimable slab In-Reply-To: <20100709191308.FA25.A69D9226@jp.fujitsu.com> Message-ID: References: <20100708133152.5e556508.akpm@linux-foundation.org> <20100709171850.FA22.A69D9226@jp.fujitsu.com> <20100709191308.FA25.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 15 On Fri, 9 Jul 2010, KOSAKI Motohiro wrote: > If number of reclaimable slabs are zero, shrink_icache_memory() and > shrink_dcache_memory() return 0. but strangely shrink_slab() ignore > it and continue meaningless loop iteration. There is also a per zone/node/global counter SLAB_RECLAIM_ACCOUNT that could be used to determine if its worth looking at things at all. I saw some effort going into making the shrinkers zone aware. If so then we may be able to avoid scanning slabs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/