Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757334Ab0GIPRl (ORCPT ); Fri, 9 Jul 2010 11:17:41 -0400 Received: from stinky.trash.net ([213.144.137.162]:38726 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab0GIPRj (ORCPT ); Fri, 9 Jul 2010 11:17:39 -0400 Message-ID: <4C373D90.8070000@trash.net> Date: Fri, 09 Jul 2010 17:17:36 +0200 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, herbert.xu@redhat.com, kvm@vger.kernel.org Subject: Re: [PATCH] netfilter: add CHECKSUM target References: <20100708222913.GA4475@redhat.com> In-Reply-To: <20100708222913.GA4475@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 29 Am 09.07.2010 00:29, schrieb Michael S. Tsirkin: > This adds a `CHECKSUM' target, which can be used in the iptables mangle > table. > > You can use this target to compute and fill in the checksum in > an IP packet that lacks a checksum. This is particularly useful, > if you need to work around old applications such as dhcp clients, > that do not work well with checksum offloads, but don't want to > disable checksum offload in your device. > > The problem happens in the field with virtualized applications. > For reference, see Red Hat bz 605555, as well as > http://www.spinics.net/lists/kvm/msg37660.html > > Typical expected use (helps old dhclient binary running in a VM): > iptables -A POSTROUTING -t mangle -p udp --dport 68 -j CHECKSUM > --checksum-fill I'm not sure this is something we want to merge upstream and support indefinitely. Dave suggested this as a temporary out-of-tree workaround until the majority of guest dhcp clients are fixed. Has anything changed that makes this course of action impractical? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/