Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066Ab0GIV03 (ORCPT ); Fri, 9 Jul 2010 17:26:29 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49267 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958Ab0GIV01 convert rfc822-to-8bit (ORCPT ); Fri, 9 Jul 2010 17:26:27 -0400 MIME-Version: 1.0 In-Reply-To: <20100709203301.GA13839@merkur.ravnborg.org> References: <1278705402.1537.157.camel@gandalf.stny.rr.com> <20100709203301.GA13839@merkur.ravnborg.org> Date: Fri, 9 Jul 2010 14:25:57 -0700 Message-ID: Subject: Re: [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment to syscall metadata declarations From: Linus Torvalds To: Sam Ravnborg Cc: Steven Rostedt , LKML , Ingo Molnar , Frederic Weisbecker , Andrew Morton , Zeev Tarantov , "Rafael J. Wysocki" , Maciej@antispam.struernethosting.dk, "Rutecki <"@antispam.struernethosting.dk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 31 On Fri, Jul 9, 2010 at 1:33 PM, Sam Ravnborg wrote: > > Something like this: > (whitespace damaged) > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 48c5299..64430d3 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -133,7 +133,8 @@ > ?#endif > > ?#ifdef CONFIG_FTRACE_SYSCALLS > -#define TRACE_SYSCALLS() VMLINUX_SYMBOL(__start_syscalls_metadata) = .; ? ? ? ?\ > +#define TRACE_SYSCALLS() . = ALIGN(8); ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? \ > + ? ? ? ? ? ? ? ? ? ? ? ?VMLINUX_SYMBOL(__start_syscalls_metadata) = .; \ > ? ? ? ? ? ? ? ? ? ? ? ? *(__syscalls_metadata) ? ? ? ? ? ? ? ? ? ? ? ? \ > ? ? ? ? ? ? ? ? ? ? ? ? VMLINUX_SYMBOL(__stop_syscalls_metadata) = .; > ?#else If this is confirmed to fix it, then I would much prefer this version. That said, I do wonder whether we shouldn't do the ALIGN(8) in the DATA_DATA define instead. That's what we do for other things like this (start_markers, start__verbose, etc etc) Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/