Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754929Ab0GJNCY (ORCPT ); Sat, 10 Jul 2010 09:02:24 -0400 Received: from fanny.its.uu.se ([130.238.4.241]:59711 "EHLO fanny.its.uu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753988Ab0GJNCW (ORCPT ); Sat, 10 Jul 2010 09:02:22 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19512.28505.216012.603468@pilspetsen.it.uu.se> Date: Sat, 10 Jul 2010 15:02:17 +0200 From: Mikael Pettersson To: Michal Marek Cc: Russell King , Robert Nelson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: Build with -fno-dwarf2-cfi-asm In-Reply-To: <1278710019-3667-1-git-send-email-mmarek@suse.cz> References: <1278710019-3667-1-git-send-email-mmarek@suse.cz> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 44 Michal Marek writes: > Commit d0679c7 restricted this workaround to powerpc only, but it turns > out that ARM needs it as well. Fixes > https://bugzilla.kernel.org/show_bug.cgi?id=16310 . > > Reported-and-Tested-by: Robert Nelson > Signed-off-by: Michal Marek > --- > arch/arm/Makefile | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 64ba313..862d4ba 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -21,6 +21,11 @@ GZFLAGS :=-9 > # Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb: > KBUILD_CFLAGS +=$(call cc-option,-marm,) > > +# FIXME: the module load should be taught about the additional relocs > +# generated by this. > +# revert to pre-gcc-4.4 behaviour of .eh_frame > +KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) Appears related to gcc PR40521, which should be fixed in gcc-4.4.3, though it may have been re-broken in gcc-4.5.0 for in a corner case that may or may not apply to the kernel. There's also a related binutils issue. The above fix seems appropriate, but the FIXME comment seems wrong: this is about getting the right kind of exception unwind tables in the entire kernel, not just relocs in modules. The comment should just say: # Never generate .eh_frame: So for the fix without the comment part: Acked-by: Mikael Pettersson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/