Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247Ab0GJRsI (ORCPT ); Sat, 10 Jul 2010 13:48:08 -0400 Received: from smtprelay01.ispgateway.de ([80.67.31.24]:55867 "EHLO smtprelay01.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab0GJRsG (ORCPT ); Sat, 10 Jul 2010 13:48:06 -0400 References: <1278553580.7162.1.camel@mola> <20100708090836.GA14580@a1.tnic> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Borislav Petkov Cc: Axel Lin , linux-kernel , Matthew Garrett , Andrew Morton , Borislav Petkov , Alexey Dobriyan , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] acerhdf: make needlessly global symbols static Date: Sat, 10 Jul 2010 19:42:51 +0200 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Df-Sender: 404094 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2337 Lines: 74 Borislav Petkov writes: > From: Axel Lin > Date: Thu, Jul 08, 2010 at 09:46:20AM +0800 > >> The following symbols are needlessly defined global: >> >> thz_dev >> cl_dev >> acerhdf_dev >> acerhdf_dev_ops >> acerhdf_cooling_ops >> >> This patch makes the symbols static. >> >> Signed-off-by: Axel Lin > > Acked-by: Borislav Petkov Acked-by: Peter Feuerer > >> --- >> drivers/platform/x86/acerhdf.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c >> index 7b2384d..5caaaf0 100644 >> --- a/drivers/platform/x86/acerhdf.c >> +++ b/drivers/platform/x86/acerhdf.c >> @@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO; >> static char force_bios[16]; >> static char force_product[16]; >> static unsigned int prev_interval; >> -struct thermal_zone_device *thz_dev; >> -struct thermal_cooling_device *cl_dev; >> -struct platform_device *acerhdf_dev; >> +static struct thermal_zone_device *thz_dev; >> +static struct thermal_cooling_device *cl_dev; >> +static struct platform_device *acerhdf_dev; >> >> module_param(kernelmode, uint, 0); >> MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off"); >> @@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal, >> } >> >> /* bind callback functions to thermalzone */ >> -struct thermal_zone_device_ops acerhdf_dev_ops = { >> +static struct thermal_zone_device_ops acerhdf_dev_ops = { >> .bind = acerhdf_bind, >> .unbind = acerhdf_unbind, >> .get_temp = acerhdf_get_ec_temp, >> @@ -449,7 +449,7 @@ err_out: >> } >> >> /* bind fan callbacks to fan device */ >> -struct thermal_cooling_device_ops acerhdf_cooling_ops = { >> +static struct thermal_cooling_device_ops acerhdf_cooling_ops = { >> .get_max_state = acerhdf_get_max_state, >> .get_cur_state = acerhdf_get_cur_state, >> .set_cur_state = acerhdf_set_cur_state, >> -- >> 1.5.4.3 >> >> >> thanks and kind regards, --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/