Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752887Ab0GJVhL (ORCPT ); Sat, 10 Jul 2010 17:37:11 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54078 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347Ab0GJVhK (ORCPT ); Sat, 10 Jul 2010 17:37:10 -0400 Message-ID: <4C38E7CA.30100@zytor.com> Date: Sat, 10 Jul 2010 14:36:10 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Cyrill Gorcunov CC: Pekka Enberg , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Yinghai Lu Subject: Re: [PATCH v2] x86: Early-boot serial I/O support References: <1278790820-1817-1-git-send-email-penberg@cs.helsinki.fi> <20100710210750.GC6615@lenovo> <20100710213211.GD6615@lenovo> In-Reply-To: <20100710213211.GD6615@lenovo> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 27 On 07/10/2010 02:32 PM, Cyrill Gorcunov wrote: >> >> Yes, but I followed 'isdigit' here for symmetry and it uses 'int'. >> > > ok, I see > At the time the code was written, "bool" use in the kernel was still not really accepted as a matter of style. I think that has changed now and "bool" is preferred, except as input/output to asm statements (we don't yet trust gcc to do it sanely across versions.) As such, changing that would be good, but should be done as a separate thing. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/