Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818Ab0GJW2C (ORCPT ); Sat, 10 Jul 2010 18:28:02 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53294 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959Ab0GJW2A (ORCPT ); Sat, 10 Jul 2010 18:28:00 -0400 MIME-Version: 1.0 In-Reply-To: References: <1278705402.1537.157.camel@gandalf.stny.rr.com> <20100709203301.GA13839@merkur.ravnborg.org> <1278721339.1537.166.camel@gandalf.stny.rr.com> <20100710063459.GA14596@merkur.ravnborg.org> Date: Sat, 10 Jul 2010 15:27:25 -0700 Message-ID: Subject: Re: [PATCH] tracing: properly align linker defined symbols From: Linus Torvalds To: Sam Ravnborg Cc: Steven Rostedt , Zeev Tarantov , LKML , Ingo Molnar , Frederic Weisbecker , Andrew Morton , "Rafael J. Wysocki" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 23 On Sat, Jul 10, 2010 at 3:25 PM, Linus Torvalds wrote: > > Here's an example patch. Untested. Whatever. Ok, and by "untested", I clearly mean just that. I see a typo immediately, but you get the idea. +#define MCOUNT_REC() \ + SYMBOL_SECTION(__mcount_lock, mcount_loc) I'm too used to typing "lock", that __mcount_lock thing should obviously be "__mcount_loc" So take the patch as the RFC it is, and fix at least that typo before actually testing it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/