Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 21 Jun 2002 07:07:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 21 Jun 2002 07:07:48 -0400 Received: from etpmod.phys.tue.nl ([131.155.111.35]:39987 "EHLO etpmod.phys.tue.nl") by vger.kernel.org with ESMTP id ; Fri, 21 Jun 2002 07:07:47 -0400 Date: Fri, 21 Jun 2002 13:07:47 +0200 From: Kurt Garloff To: Linux SCSI list Cc: Linux kernel list Subject: New SCSI exc handlers: Returning cmnds? Message-ID: <20020621110747.GA28197@gum01m.etpnet.phys.tue.nl> Mail-Followup-To: Kurt Garloff , Linux SCSI list , Linux kernel list Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline User-Agent: Mutt/1.4i X-Operating-System: Linux 2.4.16-schedJ2 i686 X-PGP-Info: on http://www.garloff.de/kurt/mykeys.pgp X-PGP-Key: 1024D/1C98774E, 1024R/CEFC9215 Organization: TU/e(NL), SuSE(DE) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1898 Lines: 55 --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, converting the dc395x_trm (Tekram DC3x5 / TRM-S1040) to new exception handling, I wonder what needs to be done with queued commands when eh_abort_handler() or eh_bus_reset_handler() are called. In the old abort handler, I was feeding the command back with DID_ABORT and call scsi_done() on it, if successful. In the old reset handler, I was feeding all commands (including the one that was passed when _reset was called) that were sitting in the host adapter driver's queue with DID_RESET back to midlayer by calling scsi_done() on them.=20 How should this handled in the new EH code? Is the new EH code implicitly aborting the commands, so I don't have to do it?=20 Is the ML prepared to have scsi_done() called when doing EH? Or do I have to use some bottom half/tasklet ... type of mechanism? Do I have to give the cmnds in queueing order, or does the ML take care of the correct ordering? http://www.andante.org/scsi_error.html is scarily ignorant on that subject. Thanks for advice! --=20 Kurt Garloff Eindhoven, NL GPG key: See mail header, key servers Linux kernel development SuSE Linux AG, Nuernberg, DE SCSI, Security --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9EwkDxmLh6hyYd04RAo+HAKCPLRc+H4tpsuS7+slvQYZf3OhTJwCgycpu +XnhsjMw3OENi8OlJB5aB60= =/WNt -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/