Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313Ab0GKJ1e (ORCPT ); Sun, 11 Jul 2010 05:27:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57030 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544Ab0GKJ1b (ORCPT ); Sun, 11 Jul 2010 05:27:31 -0400 Date: Sun, 11 Jul 2010 12:21:17 +0300 From: "Michael S. Tsirkin" To: Herbert Xu Cc: Patrick McHardy , "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] netfilter: add CHECKSUM target Message-ID: <20100711092117.GA16502@redhat.com> References: <20100708222913.GA4475@redhat.com> <20100709071814.GA27964@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100709071814.GA27964@gondor.apana.org.au> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 35 On Fri, Jul 09, 2010 at 03:18:14PM +0800, Herbert Xu wrote: > On Fri, Jul 09, 2010 at 01:29:13AM +0300, Michael S. Tsirkin wrote: > > This adds a `CHECKSUM' target, which can be used in the iptables mangle > > table. > > > > You can use this target to compute and fill in the checksum in > > an IP packet that lacks a checksum. This is particularly useful, > > if you need to work around old applications such as dhcp clients, > > that do not work well with checksum offloads, but don't want to > > disable checksum offload in your device. > > > > The problem happens in the field with virtualized applications. > > For reference, see Red Hat bz 605555, as well as > > http://www.spinics.net/lists/kvm/msg37660.html > > > > Typical expected use (helps old dhclient binary running in a VM): > > iptables -A POSTROUTING -t mangle -p udp --dport 68 -j CHECKSUM > > --checksum-fill > > > > Signed-off-by: Michael S. Tsirkin > > I'd think that this target would be protocol-agnostic, no? Meaning it should go into net/netfilter/? Will do. > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/