Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336Ab0GKNZe (ORCPT ); Sun, 11 Jul 2010 09:25:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753769Ab0GKNZa (ORCPT ); Sun, 11 Jul 2010 09:25:30 -0400 Date: Sun, 11 Jul 2010 16:19:28 +0300 From: "Michael S. Tsirkin" To: Changli Gao Cc: Jan Engelhardt , Patrick McHardy , "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, herbert.xu@redhat.com, kvm@vger.kernel.org Subject: Re: [PATCH] netfilter: add CHECKSUM target Message-ID: <20100711131928.GB3461@redhat.com> References: <20100708222913.GA4475@redhat.com> <20100711122708.GA3573@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 34 On Sun, Jul 11, 2010 at 08:45:01PM +0800, Changli Gao wrote: > On Sun, Jul 11, 2010 at 8:27 PM, Michael S. Tsirkin wrote: > > On Fri, Jul 09, 2010 at 11:56:26AM +0200, Jan Engelhardt wrote: > >> > >> On Friday 2010-07-09 00:29, Michael S. Tsirkin wrote: > >> > > >> > include/linux/netfilter_ipv4/ipt_CHECKSUM.h | ? 18 +++++++ > >> > net/ipv4/netfilter/Kconfig ? ? ? ? ? ? ? ? ?| ? 16 ++++++ > >> > net/ipv4/netfilter/Makefile ? ? ? ? ? ? ? ? | ? ?1 + > >> > net/ipv4/netfilter/ipt_CHECKSUM.c ? ? ? ? ? | ? 72 +++++++++++++++++++++++++++ > >> > >> New modules should use xt. > > > > I tried moving the module to xt_CHECKSUM but now > > ? ? ? ?iptables -A POSTROUTING -t mangle -p udp --dport 68 -j CHECKSUM --checksum-fill > > does not to load the module. > > It seems that xt_request_find_target in x_tables uses the prefix 'ip' for a module. > > What am I missing? > > > > You should add MODULE_ALIAS clause, i.e. > > MODULE_ALIAS("ipt_CHECKSUM"); This worked, thanks! > -- > Regards, > Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/