Date: Mon, 12 Jul 2010 21:23:47 +0800
From: Yong Zhang <yong.zhang@windriver.com>
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@linux-foundation.org, mingo@elte.hu, linux-kernel@vger.kernel.org,
        jeff@garzik.org, akpm@linux-foundation.org, rusty@rustcorp.com.au,
        cl@linux-foundation.org, dhowells@redhat.com, arjan@linux.intel.com,
        oleg@redhat.com, axboe@kernel.dk, fweisbec@gmail.com,
        dwalker@codeaurora.org, stefanr@s5r6.in-berlin.de, florian@mickler.org,
        andi@firstfloor.org, mst@redhat.com, randy.dunlap@oracle.com
Subject: Re: [PATCH] workqueue: fix locking in retry path of
 maybe_create_worker()
Message-ID: <20100712132347.GA19305@windriver.com>
Reply-To: Yong Zhang <yong.zhang@windriver.com>
References: <1277759063-24607-1-git-send-email-tj@kernel.org>
 <1277759063-24607-28-git-send-email-tj@kernel.org>
 <20100709091138.GA7304@windriver.com>
 <4C3AD7FE.2050702@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4C3AD7FE.2050702@kernel.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 763
Lines: 20

On Mon, Jul 12, 2010 at 10:53:18AM +0200, Tejun Heo wrote:
> maybe_create_worker() mismanaged locking when worker creation fails
> and it has to retry.  Fix locking and simplify lock manipulation.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Yong Zhang <yong.zhang@windriver.com>
> ---
> Heh, that was stupid.  Thanks a lot for spotting it.  I simplified
> things a bit there as there's no reason to repeatedly lock and unlock
> there.  Does this look good to you?

Yeah, this is better.

Thanks,
Yong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/