Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756242Ab0GLPx2 (ORCPT ); Mon, 12 Jul 2010 11:53:28 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:45348 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754061Ab0GLPx0 convert rfc822-to-8bit (ORCPT ); Mon, 12 Jul 2010 11:53:26 -0400 MIME-Version: 1.0 In-Reply-To: <20100713094226.33b421dd@debxo> References: <20100713094226.33b421dd@debxo> From: Grant Likely Date: Mon, 12 Jul 2010 09:53:04 -0600 X-Google-Sender-Auth: SltvdVDPXleVGe7t84j_EplNL6U Message-ID: Subject: Re: [PATCH] sparc: move is_root_node from private header to of.h To: Andres Salomon Cc: devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 43 On Tue, Jul 13, 2010 at 3:42 AM, Andres Salomon wrote: > > Make is_root_node available for all archs to use, as it's not PROM-specific. > Also rename it to of_is_root_node, and a few other minor changes for > style/consistency. > > Signed-off-by: Andres Salomon > --- > ?arch/sparc/kernel/prom.h ? ? ? ?| ? ?8 -------- > ?arch/sparc/kernel/prom_64.c ? ? | ? ?6 +++--- > ?arch/sparc/kernel/prom_common.c | ? ?2 +- > ?include/linux/of.h ? ? ? ? ? ? ?| ? ?8 ++++++++ > ?4 files changed, 12 insertions(+), 12 deletions(-) [...] > diff --git a/include/linux/of.h b/include/linux/of.h > index a367e19..b38cdf7 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -97,6 +97,14 @@ extern struct device_node *of_node_get(struct device_node *node); > ?extern void of_node_put(struct device_node *node); > ?#endif > > +static inline bool of_is_root_node(const struct device_node *node) > +{ > + ? ? ? if (!node) > + ? ? ? ? ? ? ? return false; > + > + ? ? ? return (node->parent == NULL); > +} Are you okay if I shorten this to? +static inline bool of_is_root_node(const struct device_node *node) +{ + return (node && (node->parent == NULL)); +} g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/