Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402Ab0GLWIa (ORCPT ); Mon, 12 Jul 2010 18:08:30 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:35633 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043Ab0GLWI2 (ORCPT ); Mon, 12 Jul 2010 18:08:28 -0400 Message-ID: <4C3B923F.1090703@metafoo.de> Date: Tue, 13 Jul 2010 00:07:59 +0200 From: Lars-Peter Clausen User-Agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100329) MIME-Version: 1.0 To: Randy Dunlap CC: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Andrew Morton , Matt Fleming , linux-mmc@vger.kernel.org Subject: Re: [PATCH v4] MMC: Add JZ4740 mmc driver References: <1277688041-23522-1-git-send-email-lars@metafoo.de> <1278970413-21617-1-git-send-email-lars@metafoo.de> <4C3B8C13.3040009@oracle.com> In-Reply-To: <4C3B8C13.3040009@oracle.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2839 Lines: 90 Hi Randy Dunlap wrote: > Lars-Peter Clausen wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> Signed-off-by: Lars-Peter Clausen >> Acked-by: Matt Fleming >> Cc: Andrew Morton >> Cc: Matt Fleming >> Cc: linux-mmc@vger.kernel.org >> >> --- >> arch/mips/include/asm/mach-jz4740/jz4740_mmc.h | 15 + >> drivers/mmc/host/Kconfig | 8 + >> drivers/mmc/host/Makefile | 1 + >> drivers/mmc/host/jz4740_mmc.c | 1024 ++++++++++++++++++++++++ >> 4 files changed, 1048 insertions(+), 0 deletions(-) >> create mode 100644 arch/mips/include/asm/mach-jz4740/jz4740_mmc.h >> create mode 100644 drivers/mmc/host/jz4740_mmc.c >> >> diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h b/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h >> new file mode 100644 >> index 0000000..8543f43 >> --- /dev/null >> +++ b/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h >> @@ -0,0 +1,15 @@ >> +#ifndef __LINUX_MMC_JZ4740_MMC >> +#define __LINUX_MMC_JZ4740_MMC >> + >> +struct jz4740_mmc_platform_data { >> + int gpio_power; >> + int gpio_card_detect; >> + int gpio_read_only; >> + unsigned card_detect_active_low:1; >> + unsigned read_only_active_low:1; >> + unsigned power_active_low:1; >> + >> + unsigned data_1bit:1; >> +}; >> + >> +#endif >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index f06d06e..546fc49 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -81,6 +81,14 @@ config MMC_RICOH_MMC >> >> If unsure, say Y. >> >> +config MMC_JZ4740 >> + tristate "JZ4740 SD/Multimedia Card Interface support" >> + depends on MACH_JZ4740 > > What tree has the kconfig symbol MACH_JZ4740 in it? > I can't seem to find it... > > Should the depends also say anything about GPIO? > I only ask because the header file above mentions gpio. > None yet, mips hopefully soon. Version 1 of this patch was part of a series adding support for the JZ4740. Since the jz4740 platform code provides the gpio functions I don't think it is necessary to add an additional depends on GENERIC_GPIO. >> + help >> + This selects the Ingenic Z4740 SD/Multimedia card Interface. >> + If you have an ngenic platform with a Multimedia Card slot, > > Ingenic ? > Woops, yes. >> + say Y or M here. >> + >> config MMC_SDHCI_OF >> tristate "SDHCI support on OpenFirmware platforms" >> depends on MMC_SDHCI && PPC_OF > > Thanks for reviewing - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/