Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364Ab0GMGF0 (ORCPT ); Tue, 13 Jul 2010 02:05:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5013 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032Ab0GMGFY (ORCPT ); Tue, 13 Jul 2010 02:05:24 -0400 Message-ID: <4C3C021E.1000709@redhat.com> Date: Tue, 13 Jul 2010 09:05:18 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: Xiao Guangrong CC: Marcelo Tosatti , LKML , KVM list Subject: Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache() References: <4C330918.6040709@cn.fujitsu.com> <4C330A37.8080709@cn.fujitsu.com> <4C39C1AB.6000606@redhat.com> <4C3A8694.1000401@cn.fujitsu.com> <4C3B09FD.3060307@redhat.com> <4C3BBE84.30708@cn.fujitsu.com> <4C3BE9BD.40007@redhat.com> <4C3BEAC3.9000501@cn.fujitsu.com> <4C3BFB25.2010602@redhat.com> <4C3BFE12.4060009@cn.fujitsu.com> In-Reply-To: <4C3BFE12.4060009@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 32 On 07/13/2010 08:48 AM, Xiao Guangrong wrote: > >> Right. We should fix those too. >> >> Prefetch is much more worrying though, especially with ept. If a guest >> is using just 1/8 of the pages, it can look to migration as if it's >> using 100% of the pages. The impact can be pretty large. >> > We disabled prefetch if ept is enabled since it can break access bit tracking. > Oh yes. > I'll fix the dirty bit tracking before post the new version of this patchset. > Should be simple - disable prefetch for slots that have dirty tracking enabled. What about the Linux accessed and dirty bits? Need to instantiate the speculative sptes with accessed and dirty bits clear (and later examine them when we release the page). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/