Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823Ab0GMILV (ORCPT ); Tue, 13 Jul 2010 04:11:21 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:41284 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350Ab0GMILQ (ORCPT ); Tue, 13 Jul 2010 04:11:16 -0400 Date: Tue, 13 Jul 2010 01:10:13 -0700 From: Joel Becker To: "Patrick J. LoPresti" Cc: Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge (> 16 TiB) volumes to mount Message-ID: <20100713081013.GA31479@mail.oracle.com> Mail-Followup-To: "Patrick J. LoPresti" , Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com References: <871vbax86w.fsf@patl.com> <87zkxyvtjt.fsf@patl.com> <3BB069D5-B193-43A4-B678-B3CEA4873B58@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4C3C1FA0.0036:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 38 On Mon, Jul 12, 2010 at 10:00:10PM -0700, Patrick J. LoPresti wrote: > On Mon, Jul 12, 2010 at 9:46 PM, Andreas Dilger wrote: > > On 2010-07-12, at 19:08, Patrick J. LoPresti wrote: > >> > >> Are you suggesting I need to do this before my patch is accepted at > >> all? ?Or is this a refactoring that can happen later? > > > > I'm just suggesting it should be done at some point. ?I thought it would be better to do it first, rather than add yet another copy of this code. ?That said, I hate to block useful fixes because of cleanup (and I have no control over OCFS2 anyway :-). ?However, I've found that once the fix is in people usually forget (or become too busy) to do the cleanup and it just lingers on unseen. > > I hear you. > > I do not object to factoring out the basic addressability test and > using it in my patch, leaving it for others -- like yourself :-) -- to > modify other file systems to invoke it. I think you should modify ext3 and xfs, as they clearly are partaking of this functionality. I'll happily review it for you. Put the call in fs/libfs.c. Call it generic_check_addressable(struct super_block *super). Joel -- "The only way to get rid of a temptation is to yield to it." - Oscar Wilde Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/