Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755436Ab0GMJ7f (ORCPT ); Tue, 13 Jul 2010 05:59:35 -0400 Received: from www.tglx.de ([62.245.132.106]:35193 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754627Ab0GMJ7d (ORCPT ); Tue, 13 Jul 2010 05:59:33 -0400 Date: Tue, 13 Jul 2010 11:58:56 +0200 (CEST) From: Thomas Gleixner To: Darren Hart cc: "lkml, " , Peter Zijlstra , Ingo Molnar , Eric Dumazet , John Kacur , Steven Rostedt , Mike Galbraith , linux-rt-users Subject: Re: [PATCH][RT] futex: protect against pi_blocked_on corruption during requeue PI In-Reply-To: <4C3C1DCF.9090509@us.ibm.com> Message-ID: References: <1278478019.10245.77.camel@marge.simson.net> <4C3C1DCF.9090509@us.ibm.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 19 On Tue, 13 Jul 2010, Darren Hart wrote: > diff --git a/kernel/futex.c b/kernel/futex.c > index a6cec32..c92978d 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -1336,6 +1336,9 @@ retry_private: > requeue_pi_wake_futex(this, &key2, hb2); > drop_count++; > continue; > + } else if (ret == -EAGAIN) { > + /* Waiter woken by timeout or signal. */ This leaks the pi_state. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/