From: Arnd Bergmann <arnd@arndb.de>
To: Martyn Welch <martyn.welch@ge.com>
Subject: Re: [PATCH 01/12] staging: autoconvert trivial BKL users to private mutex
Date: Tue, 13 Jul 2010 13:46:53 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
        "Greg Kroah-Hartman" <gregkh@suse.de>, devel@driverdev.osuosl.org
References: <1278883143-29035-1-git-send-email-arnd@arndb.de> <1278883143-29035-2-git-send-email-arnd@arndb.de> <4C3C2387.3090900@ge.com>
In-Reply-To: <4C3C2387.3090900@ge.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201007131346.53926.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 26

On Tuesday 13 July 2010, Martyn Welch wrote:

> > -     lock_kernel();
> > +     mutex_lock(&vme_user_mutex);
> >       ret = vme_user_ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
> > -     unlock_kernel();
> > +     mutex_unlock(&vme_user_mutex);
> >   
> 
> Wha!, where'd that come from!!??
> 
> Ah, OK - "Staging: push down BKL into ioctl functions", missed that,
> looks fine.
> <http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=b1f2ac07636aadee5cb077fc7e830908b00fcaae>
> 

Both patches only did blind conversions to drive the BKL out. Feel free to
kill off that mutex and the vme_user_unlocked_ioctl() function in there again
if you are convinced that no locking is actually needed in there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/