Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756703Ab0GMNKx (ORCPT ); Tue, 13 Jul 2010 09:10:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55417 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620Ab0GMNKw (ORCPT ); Tue, 13 Jul 2010 09:10:52 -0400 From: Jeff Moyer To: Gui Jianfeng Cc: Jens Axboe , Vivek Goyal , Corrado Zoccolo , linux kernel mailing list Subject: Re: [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload References: <4C3BCDA1.5040007@cn.fujitsu.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 13 Jul 2010 09:10:37 -0400 In-Reply-To: <4C3BCDA1.5040007@cn.fujitsu.com> (Gui Jianfeng's message of "Tue, 13 Jul 2010 10:21:21 +0800") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 16 Gui Jianfeng writes: > It doesn't make sence to store left time slice for an idle workload > or for the cfqq that uses up its slice. Did you actually observe any problems? As I understand it, if you overrun your slice you get a negative offset, so I think we want to keep that. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/