Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753316Ab0GNBM4 (ORCPT ); Tue, 13 Jul 2010 21:12:56 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:63992 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751137Ab0GNBMy (ORCPT ); Tue, 13 Jul 2010 21:12:54 -0400 Message-ID: <4C3D0E27.6050905@cn.fujitsu.com> Date: Wed, 14 Jul 2010 09:08:55 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Marcelo Tosatti CC: Avi Kivity , LKML , KVM list Subject: Re: [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path References: <4C3C3518.7080505@cn.fujitsu.com> <20100713212801.GA6370@amt.cnet> In-Reply-To: <20100713212801.GA6370@amt.cnet> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 19 Marcelo Tosatti wrote: entry = *spte; >> mmu_pte_write_zap_pte(vcpu, sp, spte); >> + >> + if (!!is_pae(vcpu) != sp->role.cr4_pae || >> + is_nx(vcpu) != sp->role.nxe) >> + continue; >> + > > This breaks remote_flush assignment below. Ah, Oops, will fix -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/