Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754805Ab0GNB2W (ORCPT ); Tue, 13 Jul 2010 21:28:22 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:54191 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754110Ab0GNB2V (ORCPT ); Tue, 13 Jul 2010 21:28:21 -0400 Message-ID: <4C3D11C6.4000101@cn.fujitsu.com> Date: Wed, 14 Jul 2010 09:24:22 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Marcelo Tosatti CC: Avi Kivity , LKML , KVM list Subject: Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly References: <4C3C3518.7080505@cn.fujitsu.com> <4C3C35B7.50101@cn.fujitsu.com> <20100713220551.GB6370@amt.cnet> In-Reply-To: <20100713220551.GB6370@amt.cnet> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 24 Marcelo Tosatti wrote: > On Tue, Jul 13, 2010 at 05:45:27PM +0800, Xiao Guangrong wrote: >> In speculative path, the page is not real write-access, no need mark it >> dirty, so clear dirty bit in this path and later examine this bit when >> we release the page >> >> Signed-off-by: Xiao Guangrong >> --- >> arch/x86/kvm/mmu.c | 24 +++++++++++------------- >> 1 files changed, 11 insertions(+), 13 deletions(-) > > Unfortunately all pages that kvm creates translations for are marked > dirty due to get_user_pages(w=1), except KSM which makes them read-only > later. Marcelo, i have looked into get_user_pages() function, but not catch where to make page dirty, could you point it out for me? :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/