Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754938Ab0GNBvk (ORCPT ); Tue, 13 Jul 2010 21:51:40 -0400 Received: from nlpi157.sbcis.sbc.com ([207.115.36.171]:40235 "EHLO nlpi157.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754121Ab0GNBvi (ORCPT ); Tue, 13 Jul 2010 21:51:38 -0400 Date: Tue, 13 Jul 2010 20:50:14 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: KOSAKI Motohiro cc: Andrew Morton , LKML , linux-mm , Mel Gorman , Rik van Riel , Minchan Kim , Johannes Weiner Subject: Re: [PATCH v2 1/2] vmscan: don't subtraction of unsined In-Reply-To: <20100713182918.EA67.A69D9226@jp.fujitsu.com> Message-ID: References: <20100709090956.CD51.A69D9226@jp.fujitsu.com> <20100709152851.330bf2b2.akpm@linux-foundation.org> <20100713182918.EA67.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 19 On Tue, 13 Jul 2010, KOSAKI Motohiro wrote: > Christoph, Can we hear your opinion about to add new branch in slab-free path? > I think this is ok, because reclaim makes a lot of cache miss then branch > mistaken is relatively minor penalty. thought? Its on the slow path so I would think that should be okay. But is this really necessary? Working with the per zone slab reclaim counters is not enough? We are adding counter after counter that have similar purposes and the handling gets more complex. Maybe we can get rid of the code in the slabs instead by just relying on the difference of the zone counters? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/