Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880Ab0GNF52 (ORCPT ); Wed, 14 Jul 2010 01:57:28 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64966 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751248Ab0GNF51 (ORCPT ); Wed, 14 Jul 2010 01:57:27 -0400 Message-ID: <4C3D50D7.9010207@cn.fujitsu.com> Date: Wed, 14 Jul 2010 13:53:27 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Xiao Guangrong CC: Avi Kivity , LKML , KVM list , Marcelo Tosatti Subject: Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly References: <4C3C3518.7080505@cn.fujitsu.com> <4C3C35B7.50101@cn.fujitsu.com> In-Reply-To: <4C3C35B7.50101@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 22 Xiao Guangrong wrote: > > spte = rmap_next(kvm, rmapp, NULL); > @@ -1879,9 +1877,9 @@ static int set_spte(struct kvm_vcpu *vcpu, u64 *sptep, > * whether the guest actually used the pte (in order to detect > * demand paging). > */ > - spte = shadow_base_present_pte | shadow_dirty_mask; > + spte = shadow_base_present_pte; > if (!speculative) > - spte |= shadow_accessed_mask; > + spte |= shadow_accessed_mask | shadow_dirty_mask; It breaks read-only shadow page, i'll update it... please ignore this version... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/