Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756652Ab0GNQOT (ORCPT ); Wed, 14 Jul 2010 12:14:19 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38696 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541Ab0GNQOS convert rfc822-to-8bit (ORCPT ); Wed, 14 Jul 2010 12:14:18 -0400 MIME-Version: 1.0 In-Reply-To: <4C3DDDFF.5040302@letzte-bankreihe.de> References: <4C3DDDFF.5040302@letzte-bankreihe.de> Date: Wed, 14 Jul 2010 09:13:39 -0700 Message-ID: Subject: Re: [PATCH] enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5 From: Linus Torvalds To: Stephan Wolf Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Andreas Herrmann Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 39 On Wed, Jul 14, 2010 at 8:55 AM, Stephan Wolf wrote: > > ?After commit 30a564be9d9554c168a654eddc2165869cc0d7bf "x86, hpet: Restrict > read back to affected ATI chipsets" hpet did not work anymore on HP nx6325. > The machine hangs on booting until a keystroke was taken. After a short time > machine hangs again until next keystroke. Applying the following patch > solves the issue for me. Ok, this makes sense. Bugs in the ATI chipset is why 'hpet_readback_cmp' exists in the first place. HOWEVER, clearly that commit changed it to be about too few ATI chipsets. So right now, for - PCI_DEVICE_ID_ATI_SBX00_SMBUS: force disable HPET MSI force HPET readback - PCI_DEVICE_ID_ATI_IXP400_SMBU force-enable HPET ...and than your patch makes it force HPET readback but that doesn't actually make much sense in the bigger picture, because there are other ATI chipsets that are related and presumably also affected. What about IXP[23]00_SMBUS? And what about the IXP7 series (SBX00 is IXP6, afaik)? So I get the feeling that this is incomplete, or at least needs thinking about those other ATI chipsets too. Thomas? And I added Andreas to the cc, maybe he knows what's up. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/