Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933912Ab0GORg0 (ORCPT ); Thu, 15 Jul 2010 13:36:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18818 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758643Ab0GORgX (ORCPT ); Thu, 15 Jul 2010 13:36:23 -0400 Date: Thu, 15 Jul 2010 13:36:15 -0400 From: Eric Paris To: John Johansen Cc: Eric Paris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 02/13] AppArmor: basic auditing infrastructure. Message-ID: <20100715133615.0a83defa@redhat.com> In-Reply-To: <4C3F391E.5060408@canonical.com> References: <1279154621-25868-1-git-send-email-john.johansen@canonical.com> <1279154621-25868-3-git-send-email-john.johansen@canonical.com> <4C3F391E.5060408@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 42 On Thu, 15 Jul 2010 09:36:46 -0700 John Johansen wrote: > On 07/15/2010 08:18 AM, Eric Paris wrote: > > On Wed, Jul 14, 2010 at 8:43 PM, John Johansen > > wrote: > >> + if (sa->aad.profile) { > >> + struct aa_profile *profile = sa->aad.profile; > >> + pid_t pid; > >> + rcu_read_lock(); > >> + pid = tsk->real_parent->pid; > >> + rcu_read_unlock(); > >> + audit_log_format(ab, " parent=%d", pid); > >> + audit_log_format(ab, " profile="); > >> + if (profile->ns != root_ns) { > >> + audit_log_format(ab, ":"); > >> + audit_log_untrustedstring(ab, > >> profile->ns->base.hname); > >> + audit_log_format(ab, "://"); > >> + } > >> + audit_log_untrustedstring(ab, profile->base.hname); > >> + } > > > > what does this message look like? I don't think it fits the nice > > key=value rules of the audit system.... Are you sure this is what > > you want? > > > it looks like > profile=:ns_name://profile_name Actually it would be: profile=:"ns_name"://"profile_name" The 'untrustedstring' call is going to add "" just making sure you are ok with that. I guess the audit libs will deal with it ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/