Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934007Ab0GOSJv (ORCPT ); Thu, 15 Jul 2010 14:09:51 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43867 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933978Ab0GOSJt (ORCPT ); Thu, 15 Jul 2010 14:09:49 -0400 Date: Thu, 15 Jul 2010 14:09:46 -0400 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: add context argument to shrinker callback Message-ID: <20100715180946.GA14554@infradead.org> References: <1279194418-16119-1-git-send-email-david@fromorbit.com> <1279194418-16119-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279194418-16119-2-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 22 On Thu, Jul 15, 2010 at 09:46:56PM +1000, Dave Chinner wrote: > From: Dave Chinner > > The current shrinker implementation requires the registered callback > to have global state to work from. This makes it difficult to shrink > caches that are not global (e.g. per-filesystem caches). Pass the shrinker > structure to the callback so that users can embed the shrinker structure > in the context the shrinker needs to operate on and get back to it in the > callback via container_of(). > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/