Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934272Ab0GOViX (ORCPT ); Thu, 15 Jul 2010 17:38:23 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:65204 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933759Ab0GOViT (ORCPT ); Thu, 15 Jul 2010 17:38:19 -0400 Message-ID: <4C3F7FAD.5010106@metafoo.de> Date: Thu, 15 Jul 2010 23:37:49 +0200 From: Lars-Peter Clausen User-Agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100329) MIME-Version: 1.0 To: Andrew Morton CC: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Matt Fleming , linux-mmc@vger.kernel.org Subject: Re: [PATCH v6] MMC: Add JZ4740 mmc driver References: <1278973245-25451-1-git-send-email-lars@metafoo.de> <1279227964-17801-1-git-send-email-lars@metafoo.de> <20100715141653.1c0b6a8d.akpm@linux-foundation.org> In-Reply-To: <20100715141653.1c0b6a8d.akpm@linux-foundation.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 39 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Andrew Morton wrote: > On Thu, 15 Jul 2010 23:06:04 +0200 > Lars-Peter Clausen wrote: > >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> >> ... >> >> + if (gpio_is_valid(host->pdata->gpio_power)) >> + gpio_set_value(host->pdata->gpio_power, >> + !host->pdata->power_active_low); >> >> ... >> > > Should this driver have a `depends on GPIOLIB' in Kconfig? > The driver depends on MACH_JZ4740 which selects ARCH_REQUIRE_GPIOLIB, so there already is an implicit depends on GPIOLIB. - - Lars -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEUEARECAAYFAkw/f60ACgkQBX4mSR26RiNexQCfUXt0cqiMqEf17k+z+q6XVwRO ImEAmPKxeyX9ANVasUNL60f51GxKofg= =3NrE -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/