Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935194Ab0GPBUR (ORCPT ); Thu, 15 Jul 2010 21:20:17 -0400 Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:49256 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935183Ab0GPBUO (ORCPT ); Thu, 15 Jul 2010 21:20:14 -0400 Date: Thu, 15 Jul 2010 18:20:14 -0700 (PDT) From: Shreyas Bhatewara X-X-Sender: sbhatewara@localhost.localdomain To: David Miller cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pv-drivers@vmware.com" Subject: Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [3/5] Initialize link state at probe time In-Reply-To: <20100714.141054.48510602.davem@davemloft.net> Message-ID: References: <20100714.141054.48510602.davem@davemloft.net> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 31 On Wed, 14 Jul 2010, David Miller wrote: > From: Shreyas Bhatewara > Date: Tue, 13 Jul 2010 17:48:55 -0700 (PDT) > > > > > Initialize vmxnet3 link state at probe time > > > > This change initializes the state of link at the time when driver is > > loaded. The ethtool output for 'link detected' and 'link speed' > > is thus valid even before the interface is brought up. > > > > Signed-off-by: Shreyas Bhatewara > > You should never, ever, call netif_start_queue() on a device which has > not been brought up. > > But that is what this patch is doing. > I do not understand why you say so. vmxnet3_check_link() is called in probe() with affectTxQueue as false. Hence netif_start_queue() will not be called before device is brought up. vmxnet3_check_link() is again called with affectTxQueue as true in vmxnet3_activate_dev() after device was activated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/