Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935229Ab0GPBiu (ORCPT ); Thu, 15 Jul 2010 21:38:50 -0400 Received: from tundra.namei.org ([65.99.196.166]:55504 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935038Ab0GPBis (ORCPT ); Thu, 15 Jul 2010 21:38:48 -0400 Date: Fri, 16 Jul 2010 11:38:43 +1000 (EST) From: James Morris To: Tvrtko Ursulin cc: "greg@kroah.com" , Al Viro , "linux-kernel@vger.kernel.org" , linux-security-module@vger.kernel.org Subject: Re: [PATCH][securityfs][2.6.34] Drop dentry reference count when mknod fails In-Reply-To: <201007151325.06942.tvrtko.ursulin@sophos.com> Message-ID: References: <201007151325.06942.tvrtko.ursulin@sophos.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 22 On Thu, 15 Jul 2010, Tvrtko Ursulin wrote: > > lookup_one_len increments dentry reference count which is not decremented > when the create operation fails. This can cause a kernel BUG at > fs/dcache.c:676 at unmount time. Also error code returned when new_inode() > fails was replaced with more appropriate -ENOMEM. > > > Signed-off-by: Tvrtko Ursulin Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/