Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577Ab0GPE3S (ORCPT ); Fri, 16 Jul 2010 00:29:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab0GPE3Q (ORCPT ); Fri, 16 Jul 2010 00:29:16 -0400 Date: Thu, 15 Jul 2010 21:28:45 -0700 From: Greg KH To: Peter H?we Cc: Kernel Janitors , "Digi International, Inc" , Alexey Dobriyan , Tejun Heo , Jiri Kosina , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Message-ID: <20100716042845.GA28607@suse.de> References: <201007152052.38060.PeterHuewe@gmx.de> <20100715204540.GB24463@suse.de> <201007152307.35062.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201007152307.35062.PeterHuewe@gmx.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 40 On Thu, Jul 15, 2010 at 11:07:34PM +0200, Peter H?we wrote: > Am Donnerstag 15 Juli 2010 22:45:40 schrieb Greg KH: > > The main reason I hate this macro, is that it now makes it almost > > impossible to grep for any users of the PCI_VENDOR_DIGI pci vendor id. > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > willing to take any of these patches, sorry. > > No problem ;) > Patches are just proposals - nothing else. > > The only question that remains is, do you see any point in converting the > patches to use PCI_DEVICE? > Since you have to address/set the .driver_data explicitly I guess there's no > point in doing it. > > It's > { PCI_VENDOR_DIGI, PCI_DEVICE_XRJ, PCI_ANY_ID, PCI_ANY_ID, 0, 0, brd_xrj }, > vs. > { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_XR), .driver_data=brd_xrj }, > and I guess it isn't really an improvement. It's a bit nicer, yes. But only do it if you want to. > Maybe there should be a version of PCI_DEVICE that addresses this issue? > But I have to admit, something like: > { PCI_DEVICE_DD(PCI_VENDOR_ID_DIGI, PCI_DEVICE_XR), brd_xrj }, > doesn't look that much better. You can do: { PCI_DEVICE_TABLE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_XR), brd_xrj }, just fine today, so do that if you want to. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/