Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758723Ab0GPFrA (ORCPT ); Fri, 16 Jul 2010 01:47:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60859 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184Ab0GPFq6 (ORCPT ); Fri, 16 Jul 2010 01:46:58 -0400 Date: Thu, 15 Jul 2010 22:47:38 -0700 From: Greg KH To: Joe Perches Cc: Peter Huewe , Kernel Janitors , "Digi International, Inc" , Alexey Dobriyan , Tejun Heo , Jiri Kosina , linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/25] char: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Message-ID: <20100716054738.GA30421@suse.de> References: <201007152052.38060.PeterHuewe@gmx.de> <20100715204540.GB24463@suse.de> <1279227615.5816.96.camel@Joe-Laptop.home> <20100716042943.GB28607@suse.de> <1279255463.4526.19.camel@Joe-Laptop.home> <20100716052924.GA29966@suse.de> <1279258640.4526.23.camel@Joe-Laptop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279258640.4526.23.camel@Joe-Laptop.home> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1682 Lines: 38 On Thu, Jul 15, 2010 at 10:37:20PM -0700, Joe Perches wrote: > On Thu, 2010-07-15 at 22:29 -0700, Greg KH wrote: > > On Thu, Jul 15, 2010 at 09:44:23PM -0700, Joe Perches wrote: > > > On Thu, 2010-07-15 at 21:29 -0700, Greg KH wrote: > > > > On Thu, Jul 15, 2010 at 02:00:15PM -0700, Joe Perches wrote: > > > > > On Thu, 2010-07-15 at 13:45 -0700, Greg KH wrote: > > > > > > I much prefer the PCI_DEVICE() macro instead, and as such, I'm not > > > > > > willing to take any of these patches, sorry. > > > > > grepping for pci device ids using constants and > > > > > expecting the result to be comprehensive isn't > > > > > sensible. > > > > But it's a nice goal :) > > > I think your goal is not a good one. > > > > > > For instance: > > > > > > $ grep -rP --include=*.[ch] "\bPCI_VDEVICE\s*\(\s*INTEL" drivers | wc -l > > > 201 > > > $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(PCI_VENDOR_ID_INTEL" drivers | wc -l > > > 45 > > > $ grep -rP --include=*.[ch] "\bPCI_DEVICE\s*\(\s*0x8086" drivers | wc -l > > > 38 > > > I'd much rather do a search for "PCI_VDEVICE.*INTEL" > > I'd much rather use 'cscope' or 'ctags' than trying to remember regular > > expressions like the above. > > Then it appears your original argument doesn't have much merit. I'd rather people not use PCI_VDEVICE() as then you can't easily scan for the PCI_VENDOR_ID_FOO value usage with a tool like cscope, so I think my original point stands. nevermind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/