Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964994Ab0GPKVt (ORCPT ); Fri, 16 Jul 2010 06:21:49 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:51911 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964919Ab0GPKVs (ORCPT ); Fri, 16 Jul 2010 06:21:48 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 16 Jul 2010 19:17:05 +0900 From: KAMEZAWA Hiroyuki To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Mel Gorman , Nishimura Daisuke Subject: Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized Message-Id: <20100716191705.ee8cede6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100716191256.736C.A69D9226@jp.fujitsu.com> References: <20100716191006.7369.A69D9226@jp.fujitsu.com> <20100716191256.736C.A69D9226@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 41 On Fri, 16 Jul 2010 19:13:31 +0900 (JST) KOSAKI Motohiro wrote: > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > It mean shrink_zone() only scan 32 pages and immediately return even if > it doesn't reclaim any pages. > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro Acked-by: KAMEZAWA Hiroyuki > --- > mm/vmscan.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1691ad0..bd1d035 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > struct zone *zone, int nid) > { > struct scan_control sc = { > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > .may_writepage = !laptop_mode, > .may_unmap = 1, > .may_swap = !noswap, > -- > 1.6.5.2 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/