Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965226Ab0GPLoZ (ORCPT ); Fri, 16 Jul 2010 07:44:25 -0400 Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:29430 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965175Ab0GPLoX (ORCPT ); Fri, 16 Jul 2010 07:44:23 -0400 Subject: Re: [PATCH 24/25] video/ivtv: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) From: Andy Walls To: Jarod Wilson Cc: Peter Huewe , Kernel Janitors , Mauro Carvalho Chehab , Ian Armstrong , Douglas Schilling Landgraf , Steven Toth , ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <201007152108.27175.PeterHuewe@gmx.de> <1279230200.7920.23.camel@morgan.silverblock.net> Content-Type: text/plain; charset="UTF-8" Date: Fri, 16 Jul 2010 07:42:54 -0400 Message-ID: <1279280574.2905.18.camel@morgan.silverblock.net> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.0.10011,1.0.148,0.0.0000 definitions=2010-07-16_01:2010-07-16,2010-07-16,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-1005130000 definitions=main-1007160032 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 39 On Thu, 2010-07-15 at 18:07 -0400, Jarod Wilson wrote: > On Thu, Jul 15, 2010 at 5:43 PM, Andy Walls wrote: > > On Thu, 2010-07-15 at 21:08 +0200, Peter Huewe wrote: > >> From: Peter Huewe > > a. PCI_ANY_ID indicates to the reader a wildcard match is being > > performed. The PCI_VDEVICE() macro hides that to some degree. > > > > b. PCI_VENDOR_ID_ICOMP clearly indicates that ICOMP is a vendor. > > "ICOMP" alone does not hint to the reader that is stands for a company > > (the now defunct "Internext Compression, Inc."). > > Personally, I'm a fan of comments around things like this to describe > *exactly* what device(s) they're referring to. Something like this then for ivtv: /* Claim every iTVC15/CX23415 or CX23416 based PCI Subsystem ever made */ ? > Then ICOMP being all > alone without the prefix isn't really much of an issue (though it > could still be easily mistaken for something other than a pci vendor > id, I suppose). Probably not. Another minor side effect is that it breaks a tag search for easily jumping to the definition to see the ID value. "ICOMP" won't be in the tags file, but "PCI_VENDOR_ID_ICOMP" will be. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/