Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965913Ab0GPPpd (ORCPT ); Fri, 16 Jul 2010 11:45:33 -0400 Received: from mail4.comsite.net ([205.238.176.238]:7427 "EHLO mail4.comsite.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965833Ab0GPPpc (ORCPT ); Fri, 16 Jul 2010 11:45:32 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=129.33.193.72; From: Milton Miller To: Christian Dietrich Subject: Re: [PATCH 1/2] Remove REDWOOD_[456] config options and conditional code Cc: Milton Miller , Josh Boyer , Matt Porter , Benjamin Herrenschmidt , Paul Mackerras , Solomon Peachy , David Woodhouse , Mike Frysinger , Jiri Kosina , Artem Bityutskiy , Alexander Kurz , "David S. Miller" , Randy Dunlap , John Linn , Florian Fainelli , Nicolas Pitre , Joe Perches , Ladislav Michl , David Brown , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, vamos-dev@i4.informatik.uni-erlangen.de Message-ID: In-Reply-To: <20100716142055.GA11736@zod.rchland.ibm.com> References: <4f07b3092cafbbba37d61d367cc7484e24d18d2a.1279116162.git.qy03fugy@stud.informatik.uni-erlangen.de> <20100716142055.GA11736@zod.rchland.ibm.com> Date: Fri, 16 Jul 2010 10:45:27 -0500 X-Originating-IP: 129.33.193.72 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1888 Lines: 46 On Fri, 16 Jul 2010 at about 08:20:55 -0600 Josh Boyer wrote: > On Fri, Jul 16, 2010 at 02:29:02PM +0200, Christian Dietrich wrote: > > The config options for REDWOOD_[456] were commented out in the powerpc > > Kconfig. The ifdefs referencing this options therefore are dead and all > > references to this can be removed (Also dependencies in other KConfig > > files). > This seems fine with me. > > The only question is which tree it coms through. I'm happy to take it > in via mine if the netdev and MTD people are fine with that. Otherwise, > my ack is below. > On Fri, 16 Jul 2010 around 14:29:08 +0200 Christian Dietrich wrote: > > diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig > > index f22bc9f..6629d09 100644 > > --- a/drivers/mtd/maps/Kconfig > > +++ b/drivers/mtd/maps/Kconfig > > @@ -321,7 +321,7 @@ config MTD_CFI_FLAGADM > > > > config MTD_REDWOOD > > tristate "CFI Flash devices mapped on IBM Redwood" > > - depends on MTD_CFI && ( REDWOOD_4 || REDWOOD_5 || REDWOOD_6 ) > > + depends on MTD_CFI > > help > > This enables access routines for the flash chips on the IBM > > Redwood board. If you have one of these boards and would like to > > diff --git a/drivers/mtd/maps/redwood.c b/drivers/mtd/maps/redwood.c > > index 933c0b6..d2c9db0 100644 > > --- a/drivers/mtd/maps/redwood.c > > +++ b/drivers/mtd/maps/redwood.c > > @@ -22,8 +22,6 @@ The patches are unnecssarly coupled by removing the REDWOOD_* symbols in the MTD area before removing the files and Kconfig completely in the second patch. This could easily be eliminated by pushing the two fragments into the second patch. milton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/