Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966190Ab0GPUR3 (ORCPT ); Fri, 16 Jul 2010 16:17:29 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:47520 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966137Ab0GPUR2 convert rfc822-to-8bit (ORCPT ); Fri, 16 Jul 2010 16:17:28 -0400 MIME-Version: 1.0 In-Reply-To: <1279310976.18579.8.camel@e102109-lin.cambridge.arm.com> References: <20100713230352.6781.18644.stgit@angua> <1279296221.17878.66.camel@e102109-lin.cambridge.arm.com> <20100716183028.GB26854@n2100.arm.linux.org.uk> <1279310976.18579.8.camel@e102109-lin.cambridge.arm.com> From: Grant Likely Date: Fri, 16 Jul 2010 14:17:05 -0600 X-Google-Sender-Auth: e6VDu7uvqnSE1XnJeQhOPeCIqDc Message-ID: Subject: Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig To: Catalin Marinas Cc: Linus Torvalds , Nicolas Pitre , Stephen Rothwell , Daniel Walker , Russell King - ARM Linux , linux-kbuild@vger.kernel.org, Tony Lindgren , =?ISO-8859-1?Q?Uwe_Kleine=2DK=F6nig?= , lkml , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 39 On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas wrote: > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: >> > >> > DOH. >> >> Well, it's possible that the correct approach is a mixture. >> >> Automatically do the trivial cases (recursive selects, dependencies >> that are simple or of the form "x && y" etc), and warn about the cases >> that aren't trivial (where "not trivial" may not necessarily be about >> fundamentally ambiguous ones, but just "complex enough that I won't >> even try"). > > There is still a risk with this approach when the Kconfig isn't entirely > correct. For example, on ARM we have (I pushed a patch already): > > config CPU_32v6K > ? ? ? ?depends on CPU_V6 > > config CPU_V7 > ? ? ? ?select CPU_32v6K > > In this simple approach, we end up selecting CPU_V6 when we only need > CPU_V7. There other places like this in the kernel. > > Of course, kbuild could still warn but if people rely on this feature to > select options automatically I suspect they would ignore the warnings. In my first patch, I made Kconfig problems errors instead of warnings. That would prevent people from ignoring them. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/