Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755057Ab0GQNv7 (ORCPT ); Sat, 17 Jul 2010 09:51:59 -0400 Received: from xenotime.net ([72.52.115.56]:60177 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753485Ab0GQNvy (ORCPT ); Sat, 17 Jul 2010 09:51:54 -0400 Date: Sat, 17 Jul 2010 06:51:46 -0700 From: Randy Dunlap To: Krzysztof Halasa Cc: Dimitrios Apostolou , linux-kernel@vger.kernel.org, Dan Nicolaescu Subject: Re: emacs and "linux" coding style Message-Id: <20100717065146.732f5449.rdunlap@xenotime.net> In-Reply-To: References: Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 29 On Sat, 17 Jul 2010 11:21:03 +0200 Krzysztof Halasa wrote: > Dimitrios Apostolou writes: > > > static void update_group_shares_cpu(struct task_group *tg, int cpu, > > unsigned long sd_shares, > > unsigned long sd_rq_weight, > > unsigned long *usd_rq_weight) > > { > > From a technical POV the above should not have any tabs, the parameters > should be aligned with spaces only. fwiw, it seems that you agree with Ted. > The tabs should be used for (syntactic) indentation only. > > This way we can display the code correctly with any tab length. but we know what the tab length is. ;) --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/