Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969Ab0GRGow (ORCPT ); Sun, 18 Jul 2010 02:44:52 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:36315 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750Ab0GRGou (ORCPT ); Sun, 18 Jul 2010 02:44:50 -0400 Date: Sun, 18 Jul 2010 02:44:49 -0400 From: Christoph Hellwig To: Artem Bityutskiy Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 02/16] writeback: remove redundant list initialization Message-ID: <20100718064449.GB23811@infradead.org> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-3-git-send-email-dedekind1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279284312-2411-3-git-send-email-dedekind1@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 18 On Fri, Jul 16, 2010 at 03:44:58PM +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > We do not have to call 'INIT_LIST_HEAD()' for list elements > ('bdi->bdi_list') before inserting them to the 'bdi_pending_list', > because 'list_add_tail' will initialize the element anyway. Thus, > kill the redundant initialization. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/