Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290Ab0GRG4P (ORCPT ); Sun, 18 Jul 2010 02:56:15 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:42019 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417Ab0GRG4O (ORCPT ); Sun, 18 Jul 2010 02:56:14 -0400 Date: Sun, 18 Jul 2010 02:56:13 -0400 From: Christoph Hellwig To: Artem Bityutskiy Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 10/16] writeback: simplify bdi code a little Message-ID: <20100718065613.GI23811@infradead.org> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-11-git-send-email-dedekind1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279284312-2411-11-git-send-email-dedekind1@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 503 Lines: 10 Looks correct, but I would do this slightly different. Add a new bdi_writeback_start_thread helper, and then call it from the list walk as long as there are bdis that need a thread. Only break out of the loop once nothing needs to be done and then sleep. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/