Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214Ab0GRIuA (ORCPT ); Sun, 18 Jul 2010 04:50:00 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:46752 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758Ab0GRIt5 (ORCPT ); Sun, 18 Jul 2010 04:49:57 -0400 Date: Sun, 18 Jul 2010 04:49:55 -0400 From: Christoph Hellwig To: David Howells Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL_FL [ver #6] Message-ID: <20100718084955.GB27794@infradead.org> References: <20100715021709.5544.64506.stgit@warthog.procyon.org.uk> <20100715021720.5544.19973.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100715021720.5544.19973.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 12 special is not a very useful identifier. Also what you are returning is per-filesystem data, not per-file. This needs to go into statfs, not into stat. We're about to introduce flags for statfs, so try to do it ontop of those. The same thing applies to the remote flag in the next patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/