Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757394Ab0GRVvG (ORCPT ); Sun, 18 Jul 2010 17:51:06 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33842 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757331Ab0GRVvE convert rfc822-to-8bit (ORCPT ); Sun, 18 Jul 2010 17:51:04 -0400 Date: Sun, 18 Jul 2010 14:51:20 -0700 (PDT) Message-Id: <20100718.145120.35845833.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: dipraksh@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sachinp@linux.vnet.ibm.com, benh@kernel.crashing.org, netdev@vger.kernel.org, ossthema@de.ibm.com Subject: Re: Badness with the kernel version 2.6.35-rc1-git1 running on P6 box From: David Miller In-Reply-To: <1279282842.2549.16.camel@edumazet-laptop> References: <4C401D56.3070108@linux.vnet.ibm.com> <1279274185.2549.14.camel@edumazet-laptop> <1279282842.2549.16.camel@edumazet-laptop> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 37 From: Eric Dumazet Date: Fri, 16 Jul 2010 14:20:42 +0200 > Le vendredi 16 juillet 2010 ? 11:56 +0200, Eric Dumazet a ?crit : > >> [PATCH] ehea: ehea_get_stats() should use GFP_KERNEL >> >> ehea_get_stats() is called in process context and should use GFP_KERNEL >> allocation instead of GFP_ATOMIC. >> >> Clearing stats at beginning of ehea_get_stats() is racy in case of >> concurrent stat readers. >> >> get_stats() can also use netdev net_device_stats, instead of a private >> copy. >> >> Reported-by: divya >> Signed-off-by: Eric Dumazet >> --- >> drivers/net/ehea/ehea.h | 1 - >> drivers/net/ehea/ehea_main.c | 6 ++---- >> 2 files changed, 2 insertions(+), 5 deletions(-) >> >> > > Hmm, net-next-2.6 contains following patch : If people think ehea usage is ubiquitous enough to deserve a backport of this to net-2.6, fine. But personally I don't think it's worth it. Can someone close the kernel bugzilla 16406 created for this bug? This patch we have already obviously would fix this issue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/