Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757726Ab0GSAJi (ORCPT ); Sun, 18 Jul 2010 20:09:38 -0400 Received: from gate.crashing.org ([63.228.1.57]:51117 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757646Ab0GSAJh (ORCPT ); Sun, 18 Jul 2010 20:09:37 -0400 Subject: Re: [S+Q2 07/19] slub: Allow removal of slab caches during boot From: Benjamin Herrenschmidt To: David Rientjes Cc: Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, Roland Dreier , linux-kernel@vger.kernel.org, Nick Piggin In-Reply-To: References: <20100709190706.938177313@quilx.com> <20100709190853.770833931@quilx.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 19 Jul 2010 10:07:10 +1000 Message-ID: <1279498030.10390.1760.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 30 On Wed, 2010-07-14 at 16:48 -0700, David Rientjes wrote: > On Fri, 9 Jul 2010, Christoph Lameter wrote: > > > If a slab cache is removed before we have setup sysfs then simply skip over > > the sysfs handling. > > > > Cc: Benjamin Herrenschmidt > > Cc: Roland Dreier > > Signed-off-by: Christoph Lameter > > Acked-by: David Rientjes > > I missed this case earlier because I didn't consider slab caches being > created and destroyed prior to slab_state == SYSFS, sorry! Ok so I may be a bit sleepy or something but I still fail to see how this whole thing isn't totally racy... AFAIK. By the time we switch the slab state, we -do- have all CPUs up and can race happily between creating slab caches and creating the sysfs files... Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/