Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760270Ab0GSI5A (ORCPT ); Mon, 19 Jul 2010 04:57:00 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:50191 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760247Ab0GSI45 convert rfc822-to-8bit (ORCPT ); Mon, 19 Jul 2010 04:56:57 -0400 Date: Mon, 19 Jul 2010 10:58:14 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number In-reply-to: <536935.13464.qm@web180310.mail.gq1.yahoo.com> To: Greg KH , David Brownell Cc: David Brownell , Alan Stern , Kyungmin Park , Marek Szyprowski , linux-kernel@vger.kernel.org, Dries Van Puymbroeck , stable Message-id: Organization: Samsung Electronics MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-transfer-encoding: 8BIT User-Agent: Opera Mail/10.60 (Linux) References: <536935.13464.qm@web180310.mail.gq1.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 39 On Sun, 18 Jul 2010 01:57:30 +0200, David Brownell wrote: > Still no fan, since it just duplicates > existing functionality from the composite > framework. Using the existing mechanism > seems preferable to me: you want a serial > number? provide one using the existing scheme > and just make sure it follows the rules. Hello David, I'm still not sure what you mean. As a matter of fact I think you might be confusing Mass Storage Gadget with File Storage Gadget. The first patch in the series merely adds the initialisation for the iSerialNumber field of the descriptor of Mass Storage Gadget (which is a composite gadget). It in no way duplicates functionality of the composite layer. As a matter of fact, without this patch, the iSerialNumber module parameter won't work (not tested, just looked at the code). The second patch (by Yann Cantin) adds a serial module parameter to the File Storage Gadget. FSG is not a composite gadget so the patch does not duplicate composite functionality (well it does but it's irrelevant since FSG cannot use composite anyway). The third patch is irrelevant in this discussion I believe. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/