DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=xxuNX1YO3RdU65OAHmXovQ6l94nSb1XjGVBCPG+pBNDfpnoVQEMHaUkudIXw1KTKJdsExa58/hEVLsZEhlQZg3OsK0RTui78F68J+CbFqaGQSh94IH20dGv4CQsg2fDSZKzZxxRlzFQILjWtJbkxc+Z4ATcPbSB0JNdi+ZDAnpE=;
Message-ID: <590491.14987.qm@web180309.mail.gq1.yahoo.com>
Date: Mon, 19 Jul 2010 03:08:36 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number
To: Greg KH <greg@kroah.com>,
        =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= <m.nazarewicz@samsung.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
        Alan Stern <stern@rowland.harvard.edu>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org,
        Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
        stable <stable@kernel.org>
In-Reply-To: <op.vf21vchq7p4s8u@pikus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 40


>   It in no way duplicates functionality of
> the composite layer.

Beyond the obvious "Set serial number" ...


> As a matter of fact, without
> this patch, the
> iSerialNumber module parameter won't work

So submit a bugfix for that alone, making it
work everywhere... 

> (not tested, just looked at the code).

Do you know when it broke?  That code has been
tested in the past, and observed to work.  So if
it's not working now, someone broke it and that
should just be fixed.


> The second patch (by Yann Cantin) adds a serial module
> parameter to
> the File Storage Gadget.  FSG is not a composite
> gadget 

OK, so it should add a module param with the same
name as used elsewhere ... makes sense to me.  If
Alan Acks that patch, go for it.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/